Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mentions and links to honggfuzz-rs #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add mentions and links to honggfuzz-rs #14

wants to merge 2 commits into from
+8 −2

Conversation

PaulGrandperrin
Copy link
Member

@PaulGrandperrin PaulGrandperrin commented Oct 13, 2018 •
edited
Loading

Also, I think we should remove the mention that cargo-fuzz is the recommended fuzzer in this file: https://github.com/rust-fuzz/book/blob/master/src/cargo-fuzz.md.
I think there is two reasons for this:

  • honggfuzz-rs is now available. It has its own set of strenghts and weaknesses but I honestly think it is as relevant as cargo-fuzz.
  • afs.rs has vastly improved in performance thanks to persistent fuzzing. I think it is now as relevant as the other two.

closes #10

killercup
killercup reviewed Oct 13, 2018
View reviewed changes
Copy link
Member

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is not true right now, but I also want to add that IIRC cargo-fuzz was meant to get support for other fuzzers eventually :)

src/SUMMARY.md
* [Setup](https://crates.io/crates/honggfuzz#dependencies)
* [Tutorial/Guide](https://crates.io/crates/honggfuzz#how-to-use-this-crate)
* [API](https://docs.rs/honggfuzz)
* [Related docs](https://crates.io/crates/honggfuzz#relevant-documentation-about-honggfuzz)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh? Does mdbook support external links in the TOC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea, I didn't test anything, just edited in github directly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried rendering this branch with mdbook. It appears mdbook adds a .html to the end of each of the external links, causing them to break. We might just need to create a new dedicated page for hongfuzz within this book containing all these links

@PaulGrandperrin
Copy link
Member Author

That's really fine by me to say that cargo-fuzz is intended to eventually support all fuzzers, and users would then be able to judge how much this fact is important to them.
What I think is that there is plenty of other factors to choose a fuzzer instead of another, and planned compatibility is only one of them.
The three fuzzers we have are all very interesting because they have a different set of strengths and weaknesses and I don't think we can now (in 2018) simply recommend one over the others. Maybe we will be able to do that in the future though.

@frewsxcv frewsxcv removed their request for review September 18, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv left review comments

@killercup killercup killercup left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add section about honggfuzz-rs
3 participants
@PaulGrandperrin @killercup @frewsxcv